RE: [PATCH v2 0/2] tools: power: cpupower: Allow overriding cross-compiling envs

[Peng Fan]

> Subject: RE: [PATCH v2 0/2] tools: power: cpupower: Allow overriding
> cross-compiling envs
> 
> Hi John,
> 
> > Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow
> overriding
> > cross-compiling envs
> >
> > Hi Peng,
> >
> > A few comments:
> >
> > > V2:
> > >  subject update, commit log update in patch 1, 2  Use strerror in
> > > patch 1  without patch 2, need update Makefile with 'CROSS =
> [cross
> > > toolchain path]/aarch64-poky-linux-'
> >
> > Version information is applied per commit patch. Not in the cover
> > letter.
> >

Just get this from the page:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
When sending a next version, add a patch changelog to the cover
Letter or to individual patches explaining difference against
previous submission

So it is fine to put changelog in cover-letter?

Thanks,
Peng.

> 
> Sure, I will follow in v3.
> 
> > >  without patch 2, need update Makefile with 'CROSS =  [cross
> > toolchain
> > > path]/aarch64-poky-linux-'
> >
> > I am not sure what this is saying exactly. Please clarify.
> >
> 
> Shuah asked to put that in changelog,
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> lore.kernel.org%2Fall%2F0f8df90f-007a-483e-83ce-
> df8ff0e99791%40linuxfoundation.org%2F&data=05%7C02%7Cpeng.fa
> n%40nxp.com%7C246bfa4c006340cb2f3108dcd95293ec%7C686ea1d
> 3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638624195921233948%
> 7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu
> MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=Kj9
> PVl7PaBNAMZQ0bHL7F2ZIAhcziUEkEE3vdIrYmtU%3D&reserved=0
> 
> I could put in patch 1/2 change log in V3.
> 
> > > Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow
> > overriding
> >
> > Not sure you need 'tools: power: cpupower:' in the cover letter.
> 
> Will use "tools: power:" in v3.
> >
> > > pm: cpupower: bench: print config file path when open
> > > cpufreq-bench.conf fails
> >
> > I do not think you need bench either.
> 
> Will drop "bench" in v3.
> 
> 
> Thanks,
> Peng.
> 
> >
> > --
> > Sincerely,
> > John Wyatt
> > Software Engineer, Core Kernel
> > Red Hat
>