RE: [PATCH v3] scsi: ufs: Zero utp_upiu_req at the beginning of each command

From: Avri Altman
Date: Fri Sep 20 2024 - 15:01:27 EST


> On 9/19/24 1:41 AM, Avri Altman wrote:
> > +static void __ufshcd_setup_cmd(struct ufs_hba *hba, struct ufshcd_lrb
> *lrbp,
> > + struct scsi_cmnd *cmd, u8 lun, int tag) {
> > + memset(lrbp->ucd_req_ptr, 0, sizeof(*lrbp->ucd_req_ptr));
> > +
> > + lrbp->cmd = cmd;
> > + lrbp->task_tag = tag;
> > + lrbp->lun = lun;
> > + ufshcd_prepare_lrbp_crypto(cmd ? scsi_cmd_to_rq(cmd) : NULL,
> > +lrbp); }
>
> This function does not use the 'hba' argument so please remove that
> argument. Otherwise this patch looks good to me.
Done.

Thanks,
Avri
>
> Thanks,
>
> Bart.