Re: [patch v2 3/3] riscv: dts: starfive: add framework dts
From: Rafał Miłecki
Date: Tue Sep 24 2024 - 09:35:01 EST
On 2024-09-24 10:06, Sandie Cao wrote:
diff --git a/arch/riscv/boot/dts/starfive/jh7110-framework.dts
b/arch/riscv/boot/dts/starfive/jh7110-framework.dts
new file mode 100644
index 000000000000..ff12c24ebab3
--- /dev/null
+++ b/arch/riscv/boot/dts/starfive/jh7110-framework.dts
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: GPL-2.0 OR MIT
+/*
+ * Copyright (C) 2022 StarFive Technology Co., Ltd.
+ * Copyright (C) 2022 Emil Renner Berthing <kernel@xxxxxxxx>
+ */
+
+/dts-v1/;
+#include "jh7110-common.dtsi"
+
+/ {
+ model = "Framework FRANME0000";
+ compatible = "deepcomputing,fm7110", "starfive,jh7110";
+};
Nitpicking: property "compatible" should go first.
See Documentation/devicetree/bindings/dts-coding-style.rst
--
Rafał Miłecki