Re: [patch v2 3/3] riscv: dts: starfive: add framework dts

From: Krzysztof Kozlowski
Date: Tue Sep 24 2024 - 14:41:25 EST


On 24/09/2024 10:52, 曹珊珊 wrote:
> Hi Krzysztof,
>
> Thanks for your time.
>
> A: jh7110-common.dtsi is also used by other boards. Likes: milkv-mars, 
> pine64-star64. So I can only disable them in jh7110-framework.dts. 
> Or I need to create a new common.dtsi. 
>
> Q: Why PCIE0 is enabled in the DTSI in the first place? The same questions
> about MACs.
>
> Regards,
> Sandie
>
> On 24/09/2024 10:06, Sandie Cao wrote:
>> Add framework dts to support RISC-V Framework Laptop 13 Mainboard.
>>  
>> Signed-off-by: Sandie Cao <sandie.cao@xxxxxxxxxxxxxxxx>
>> ---
>>   arch/riscv/boot/dts/starfive/Makefile         |  1 +
>>   .../boot/dts/starfive/jh7110-framework.dts    | 34 +++++++++++++++++++
>>   2 files changed, 35 insertions(+)
>>   create mode 100644 arch/riscv/boot/dts/starfive/jh7110-framework.dts
>
> Your threading is entirely broken making applying process more difficult.

So I am talking with myself?

...

>> +        status = "disabled";
>> +};
>> +
>> +&pcie0 {
>> +        status = "disabled";
>
> Why PCIE0 is enabled in the DTSI in the first place? The same questions
> about MACs.
>
> Best regards,
> Krzysztof

And sending myself regards?

Sorry, no clue what's going on here.

Best regards,
Krzysztof