Re: [PATCH v3 net] net: systemport: Add error pointer checks in bcm_sysport_map_queues() and bcm_sysport_unmap_queues()

From: Simon Horman
Date: Wed Sep 25 2024 - 07:19:27 EST


On Tue, Sep 24, 2024 at 06:56:33PM +0000, Dipendra Khadka wrote:
> Add error pointer checks in bcm_sysport_map_queues() and
> bcm_sysport_unmap_queues() after calling dsa_port_from_netdev().
>
> Fixes: d156576362c0 ("net: systemport: Establish lower/upper queue mapping")
> Fixes: da106a140f9c ("net: systemport: Unmap queues upon DSA unregister event")
> Signed-off-by: Dipendra Khadka <kdipendra88@xxxxxxxxx>

I'm sorry to be picky, but I think the fixes tag should be (only):

Fixes: 1593cd40d785 ("net: systemport: use standard netdevice notifier to detect DSA presence")

Otherwise, this looks good to me.

...