Re: [PATCH v3 net] net: systemport: Add error pointer checks in bcm_sysport_map_queues() and bcm_sysport_unmap_queues()

[Dipendra Khadka]

Hi Simon,

On Wed, 25 Sept 2024 at 17:04, Simon Horman <horms@xxxxxxxxxx> wrote:
>
> On Tue, Sep 24, 2024 at 06:56:33PM +0000, Dipendra Khadka wrote:
> > Add error pointer checks in bcm_sysport_map_queues() and
> > bcm_sysport_unmap_queues() after calling dsa_port_from_netdev().
> >
> > Fixes: d156576362c0 ("net: systemport: Establish lower/upper queue mapping")
> > Fixes: da106a140f9c ("net: systemport: Unmap queues upon DSA unregister event")
> > Signed-off-by: Dipendra Khadka <kdipendra88@xxxxxxxxx>
>
> I'm sorry to be picky, but I think the fixes tag should be (only):
>
> Fixes: 1593cd40d785 ("net: systemport: use standard netdevice notifier to detect DSA presence")
>



I have sent the v4 patch. I was checking git log -S 'function name
like bcm_sysport_map_queues'. But when I checked with the
"dsa_port_from_netdev", I got the same result as yours.Thank you once
again.

> Otherwise, this looks good to me.
>
> ...

Best regards,
Dipendra Khadka