Re: [PATCH net v4] net: systemport: Add error pointer checks in bcm_sysport_map_queues() and bcm_sysport_unmap_queues()
From: Simon Horman
Date: Wed Sep 25 2024 - 16:09:14 EST
On Wed, Sep 25, 2024 at 03:29:26PM +0000, Dipendra Khadka wrote:
> Add error pointer checks in bcm_sysport_map_queues() and
> bcm_sysport_unmap_queues() after calling dsa_port_from_netdev().
>
> Fixes: 1593cd40d785 ("net: systemport: use standard netdevice notifier to detect DSA presence")
> Signed-off-by: Dipendra Khadka <kdipendra88@xxxxxxxxx>
> ---
> v4:
> - Removed wrong and used correct Fixes: tag
> v3: https://lore.kernel.org/all/20240924185634.2358-1-kdipendra88@xxxxxxxxx/
> - Updated patch subject
> - Updated patch description
> - Added Fixes: tags
> - Fixed typo from PRT_ERR to PTR_ERR
> - Error is checked just after assignment
> v2: https://lore.kernel.org/all/20240923053900.1310-1-kdipendra88@xxxxxxxxx/
> - Change the subject of the patch to net
> v1: https://lore.kernel.org/all/20240922181739.50056-1-kdipendra88@xxxxxxxxx/
Thanks for all the updates, this version looks good to me.
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>