Re: [PATCH net v4] net: systemport: Add error pointer checks in bcm_sysport_map_queues() and bcm_sysport_unmap_queues()

From: kernel test robot
Date: Thu Sep 26 2024 - 03:21:16 EST


Hi Dipendra,

kernel test robot noticed the following build errors:

[auto build test ERROR on net/main]

url: https://github.com/intel-lab-lkp/linux/commits/Dipendra-Khadka/net-systemport-Add-error-pointer-checks-in-bcm_sysport_map_queues-and-bcm_sysport_unmap_queues/20240925-233508
base: net/main
patch link: https://lore.kernel.org/r/20240925152927.4579-1-kdipendra88%40gmail.com
patch subject: [PATCH net v4] net: systemport: Add error pointer checks in bcm_sysport_map_queues() and bcm_sysport_unmap_queues()
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240926/202409261447.R2kfrGVq-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240926/202409261447.R2kfrGVq-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409261447.R2kfrGVq-lkp@xxxxxxxxx/

All error/warnings (new ones prefixed by >>):

drivers/net/ethernet/broadcom/bcmsysport.c: In function 'bcm_sysport_unmap_queues':
>> drivers/net/ethernet/broadcom/bcmsysport.c:2401:35: error: expected ';' before ')' token
2401 | return PTR_ERR(dp));
| ^
| ;
>> drivers/net/ethernet/broadcom/bcmsysport.c:2400:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
2400 | if (IS_ERR(dp))
| ^~
drivers/net/ethernet/broadcom/bcmsysport.c:2401:35: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
2401 | return PTR_ERR(dp));
| ^
>> drivers/net/ethernet/broadcom/bcmsysport.c:2401:35: error: expected statement before ')' token


vim +2401 drivers/net/ethernet/broadcom/bcmsysport.c

2389
2390 static int bcm_sysport_unmap_queues(struct net_device *dev,
2391 struct net_device *slave_dev)
2392 {
2393 struct bcm_sysport_priv *priv = netdev_priv(dev);
2394 struct bcm_sysport_tx_ring *ring;
2395 unsigned int num_tx_queues;
2396 unsigned int q, qp, port;
2397 struct dsa_port *dp;
2398
2399 dp = dsa_port_from_netdev(slave_dev);
> 2400 if (IS_ERR(dp))
> 2401 return PTR_ERR(dp));
2402
2403 port = dp->index;
2404
2405 num_tx_queues = slave_dev->real_num_tx_queues;
2406
2407 for (q = 0; q < dev->num_tx_queues; q++) {
2408 ring = &priv->tx_rings[q];
2409
2410 if (ring->switch_port != port)
2411 continue;
2412
2413 if (!ring->inspect)
2414 continue;
2415
2416 ring->inspect = false;
2417 qp = ring->switch_queue;
2418 priv->ring_map[qp + port * num_tx_queues] = NULL;
2419 }
2420
2421 return 0;
2422 }
2423

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki