Re: [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576

From: Krzysztof Kozlowski
Date: Fri Sep 27 2024 - 03:30:46 EST


On 27/09/2024 09:01, Frank Wang wrote:
> Hi Krzysztof,
>
> On 2024/9/26 22:19, Krzysztof Kozlowski wrote:
>> On 26/09/2024 12:32, Frank Wang wrote:
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - rockchip,rk3576-usb2phy
>>> + then:
>>> + properties:
>>> + clocks:
>>> + minItems: 3
>>> + maxItems: 3
>> Read one more time the example I gave you. Top-level constraints are
>> saying max one clock.
>>
>> Best regards,
>> Krzysztof
>>
>
> Sorry for overlooking this, I will set both "clocks" and "clock-names"
> to true, and add the else case below the above codes for the "old" SoCs.
> Just like the below.
>
> -  clocks:
> -    maxItems: 1
> +  clocks: true
>
> -  clock-names:
> -    const: phyclk
> +  clock-names: true

For the third time, read the code I gave you. Do you see something like
this there? Why doing all the time something different than existing code?

Best regards,
Krzysztof