Re: [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576

[Frank Wang]

Hi Krzysztof,

On 2024/9/27 15:30, Krzysztof Kozlowski wrote:
> On 27/09/2024 09:01, Frank Wang wrote:
> > Hi Krzysztof,
> >
> > On 2024/9/26 22:19, Krzysztof Kozlowski wrote:
> > > On 26/09/2024 12:32, Frank Wang wrote:
> > > > +  - if:
> > > > +      properties:
> > > > +        compatible:
> > > > +          contains:
> > > > +            enum:
> > > > +              - rockchip,rk3576-usb2phy
> > > > +    then:
> > > > +      properties:
> > > > +        clocks:
> > > > +          minItems: 3
> > > > +          maxItems: 3
> > > Read one more time the example I gave you. Top-level constraints are
> > > saying max one clock.
> > >
> > > Best regards,
> > > Krzysztof
> > Sorry for overlooking this, I will set both "clocks" and "clock-names"
> > to true, and add the else case below the above codes for the "old" SoCs.
> > Just like the below.
> >
> > -  clocks:
> > -    maxItems: 1
> > +  clocks: true
> >
> > -  clock-names:
> > -    const: phyclk
> > +  clock-names: true
> For the third time, read the code I gave you. Do you see something like
> this there? Why doing all the time something different than existing code?

Refer to the link you sent me that I must add minItems property for 
clocks, just like the below codes:

@@ -35,7 +35,8 @@ properties:
     const: 0

   clocks:
-    maxItems: 1
+    minItems: 1
+    maxItems: 3

That can pass dt_binding and dtb checking, however, "clocks" is the 
optional property for some old Rockchip PHYs,  I am not sure is it right 
to force set  minItems as 1 .
If just keep maxItems, the dt_binding checking is failure.


Best regards,
Frank

> Best regards,
> Krzysztof