Re: [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576

From: Krzysztof Kozlowski
Date: Fri Sep 27 2024 - 05:53:03 EST


On 27/09/2024 09:59, Frank Wang wrote:
>>>
>>> -  clocks:
>>> -    maxItems: 1
>>> +  clocks: true
>>>
>>> -  clock-names:
>>> -    const: phyclk
>>> +  clock-names: true
>> For the third time, read the code I gave you. Do you see something like
>> this there? Why doing all the time something different than existing code?
>
> Refer to the link you sent me that I must add minItems property for
> clocks, just like the below codes:
>
> @@ -35,7 +35,8 @@ properties:
>      const: 0
>
>    clocks:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 3

Yes, for all variable properties, so also names.

>
> That can pass dt_binding and dtb checking, however, "clocks" is the
> optional property for some old Rockchip PHYs,  I am not sure is it right
> to force set  minItems as 1 .
> If just keep maxItems, the dt_binding checking is failure.

Please specify the question you want to ask.


Best regards,
Krzysztof