Re: [PATCH] printf: Remove unused 'bprintf'

From: Andy Shevchenko
Date: Wed Oct 02 2024 - 10:15:51 EST


On Wed, Oct 02, 2024 at 02:21:25AM +0100, linux@xxxxxxxxxxx wrote:
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> bprintf is unused. Remove it.

bprintf()

> It was added in
> commit 4370aa4aa753 ("vsprintf: add binary printf")
>
> but as far as I can see was never used, unlike the other
> two functions in that patch.

Please, rewrap these lines to use more room on each line.

...

I am not familiar with tricks in BPF or ftrace code where this actually might
be implicitly called via a macro, but brief grep gives nothing that might point
to that. Hence, with the amended commit message

Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

P.S. I hope we may rely in CIs to report issues soon, if any.

--
With Best Regards,
Andy Shevchenko