Re: [PATCH] Input: zinitix - Don't fail if linux,keycodes prop is absent

[Linus Walleij]

On Wed, Oct 2, 2024 at 3:02 PM Nikita Travkin <nikita@xxxxxxx> wrote:

> When initially adding the touchkey support, a mistake was made in the
> property parsing code. The possible negative errno from
> device_property_count_u32() was never checked, which was an oversight
> left from converting to it from the of_property as part of the review
> fixes.
>
> Re-add the correct handling of the absent property, in which case zero
> touchkeys should be assumed, which would disable the feature.
>
> Reported-by: Jakob Hauser <jahau@xxxxxxxxxxxxxx>
> Tested-by: Jakob Hauser <jahau@xxxxxxxxxxxxxx>
> Fixes: 075d9b22c8fe ("Input: zinitix - add touchkey support")
> Signed-off-by: Nikita Travkin <nikita@xxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

BTW: Nikita have you noticed and weird offsets in your Zinitix
touchscreens? Mine seem to be off and I need to put my
fingers a bit below the actual target on the screen, consistently.
I was thinking maybe calibration support is necessary.

Yours,
Linus Walleij