Re: [PATCH] printf: Remove unused 'bprintf'

[Andy Shevchenko]

On Wed, Oct 02, 2024 at 02:31:19PM +0000, Dr. David Alan Gilbert wrote:
> * Andy Shevchenko (andy@xxxxxxxxxx) wrote:
> > On Wed, Oct 02, 2024 at 02:21:25AM +0100, linux@xxxxxxxxxxx wrote:
> > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > > 
> > > bprintf is unused.  Remove it.
> > 
> > bprintf()
> 
> OK.
> 
> > > It was added in
> > > commit 4370aa4aa753 ("vsprintf: add binary printf")
> > > 
> > > but as far as I can see was never used, unlike the other
> > > two functions in that patch.
> > 
> > Please, rewrap these lines to use more room on each line.
> 
> Something like this? :

> bprintf() is unused.  Remove it.  It was added in
> 
> commit 4370aa4aa753 ("vsprintf: add binary printf")
> 
> but as far as I can see was never used, unlike the other two functions in
> that patch.

You have two blank lines in the middle, do you really need them?
I would put it like this

bprintf() is unused. Remove it. It was added in the commit 4370aa4aa753
("vsprintf: add binary printf") but as far as I can see was never used,
unlike the other two functions in that patch.

-- 
With Best Regards,
Andy Shevchenko