Re: [PATCH] printf: Remove unused 'bprintf'

[Dr. David Alan Gilbert]

* Andy Shevchenko (andy@xxxxxxxxxx) wrote:
> On Wed, Oct 02, 2024 at 02:31:19PM +0000, Dr. David Alan Gilbert wrote:
> > * Andy Shevchenko (andy@xxxxxxxxxx) wrote:
> > > On Wed, Oct 02, 2024 at 02:21:25AM +0100, linux@xxxxxxxxxxx wrote:
> > > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > > > 
> > > > bprintf is unused.  Remove it.
> > > 
> > > bprintf()
> > 
> > OK.
> > 
> > > > It was added in
> > > > commit 4370aa4aa753 ("vsprintf: add binary printf")
> > > > 
> > > > but as far as I can see was never used, unlike the other
> > > > two functions in that patch.
> > > 
> > > Please, rewrap these lines to use more room on each line.
> > 
> > Something like this? :
> 
> > bprintf() is unused.  Remove it.  It was added in
> > 
> > commit 4370aa4aa753 ("vsprintf: add binary printf")
> > 
> > but as far as I can see was never used, unlike the other two functions in
> > that patch.
> 
> You have two blank lines in the middle, do you really need them?

No, I was just trying to keep the commit reference separate, I'm never
quite sure what checkpatch gets upset by.

> I would put it like this
> 
> bprintf() is unused. Remove it. It was added in the commit 4370aa4aa753
> ("vsprintf: add binary printf") but as far as I can see was never used,
> unlike the other two functions in that patch.

Sure, I can send a v2 like that.

Dave

> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/