Re: [PATCH] acl: Realign struct posix_acl to reduce its size by 8 bytes

From: Jan Kara
Date: Fri Oct 04 2024 - 09:37:27 EST


On Fri 04-10-24 12:33:57, Thorsten Blum wrote:
> Reduce posix_acl's struct size by 8 bytes by realigning its members.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

Honza

> ---
> include/linux/posix_acl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/posix_acl.h b/include/linux/posix_acl.h
> index 83b2c5fba1d9..e2d47eb1a7f3 100644
> --- a/include/linux/posix_acl.h
> +++ b/include/linux/posix_acl.h
> @@ -28,8 +28,8 @@ struct posix_acl_entry {
>
> struct posix_acl {
> refcount_t a_refcount;
> - struct rcu_head a_rcu;
> unsigned int a_count;
> + struct rcu_head a_rcu;
> struct posix_acl_entry a_entries[] __counted_by(a_count);
> };
>
> --
> 2.46.2
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR