Re: [PATCH] acl: Realign struct posix_acl to reduce its size by 8 bytes

From: Thorsten Blum
Date: Fri Oct 04 2024 - 16:25:21 EST


On 4. Oct 2024, at 15:37, Jan Kara wrote:
> On Fri 04-10-24 12:33:57, Thorsten Blum wrote:
>> Reduce posix_acl's struct size by 8 bytes by realigning its members.
>>
>> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
>
> Looks good. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>

We should probably add:

Fixes: b0ab04a8ffd8 ("acl: Annotate struct posix_acl with __counted_by()")
Reported-by: kernel test robot <oliver.sang@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-lkp/202409260949.a1254989-oliver.sang@xxxxxxxxx

as this patch is also a workaround for a Clang __bdos() bug (see the
Closes: link for details).

Thanks,
Thorsten