Re: [PATCH v7 0/2] arm64: dts: qcom: extend the register range for ICE on sm8[56]50

From: Bjorn Andersson
Date: Fri Oct 04 2024 - 09:58:52 EST


On Tue, Oct 01, 2024 at 10:35:29AM +0200, Bartosz Golaszewski wrote:
> The following changes extend the register range for ICE IPs on sm8550
> and sm8650 in order to cover the registers used for wrapped key support
> on these platforms.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> Changes in v7:
> - bring the ICE register range up to its full size of 0x18000
> - Link to v6: https://lore.kernel.org/r/20240906-wrapped-keys-dts-v6-0-3f0287cf167e@xxxxxxxxxx
>
> Changes in v6:
> - split out the DT changes into a separate series

Bartosz, this strategy of "let's split things such that the maintainers
can't see the full picture" is just BS. It needs to stop.

Now you will argue that these patches stands on their own, and that
might be a valid case, but the argumentation you're making in the commit
message clearly ties them to the code changes you're making somewhere
else.

Regards,
Bjorn

> - remove the new DT property from the series
> - rework commit messages
> Link to v5: https://lore.kernel.org/lkml/20240617005825.1443206-1-quic_gaurkash@xxxxxxxxxxx/
>
> ---
> Bartosz Golaszewski (2):
> arm64: dts: qcom: sm8650: extend the register range for UFS ICE
> arm64: dts: qcom: sm8550: extend the register range for UFS ICE
>
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 3 ++-
> arch/arm64/boot/dts/qcom/sm8650.dtsi | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
> ---
> base-commit: 77df9e4bb2224d8ffbddec04c333a9d7965dad6c
> change-id: 20240906-wrapped-keys-dts-b733dac51d01
>
> Best regards,
> --
> Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>