Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig

From: Javier Carrasco
Date: Sat Oct 05 2024 - 14:13:11 EST


On 05/10/2024 20:01, Jonathan Cameron wrote:
> On Thu, 03 Oct 2024 23:04:58 +0200
> Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote:
>
>> This driver makes use of triggered buffers, but does not select the
>> required modules.
>>
>> Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
>>
>> Fixes: 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")
> Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the
> patch description to refer to the bm1390 which seems to be the right
> name and add a note on this as it looks suspect otherwise.
>

Yes, it seems that there was a typo in the title of the patch that added
the driver (The "Fixes:" is therefore right as it is), and I propagated
it in the title of this patch as well. But you are right, the driver's
name is indeed bm1390.

>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
>> ---
>> drivers/iio/pressure/Kconfig | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
>> index df65438c771e..d2cb8c871f6a 100644
>> --- a/drivers/iio/pressure/Kconfig
>> +++ b/drivers/iio/pressure/Kconfig
>> @@ -19,6 +19,9 @@ config ABP060MG
>> config ROHM_BM1390
>> tristate "ROHM BM1390GLV-Z pressure sensor driver"
>> depends on I2C
>> + select REGMAP_I2C
>> + select IIO_BUFFER
>> + select IIO_TRIGGERED_BUFFER
>> help
>> Support for the ROHM BM1390 pressure sensor. The BM1390GLV-Z
>> can measure pressures ranging from 300 hPa to 1300 hPa with
>>
>