Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig

From: Matti Vaittinen
Date: Sun Oct 06 2024 - 04:14:21 EST


On 05/10/2024 21:12, Javier Carrasco wrote:
On 05/10/2024 20:01, Jonathan Cameron wrote:
On Thu, 03 Oct 2024 23:04:58 +0200
Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote:

This driver makes use of triggered buffers, but does not select the
required modules.

Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.

Fixes: 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")
Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the
patch description to refer to the bm1390 which seems to be the right
name and add a note on this as it looks suspect otherwise.

Yes, it seems that there was a typo in the title of the patch that added
the driver (The "Fixes:" is therefore right as it is), and I propagated
it in the title of this patch as well. But you are right, the driver's
name is indeed bm1390.

Yep. I typoed the original patch. The correct sensor model is BM1390GLV-Z. I got things mixed up in my head as I was simultaneously writing drivers the BU270xx light sensors, a BD71851 power management IC and BU18xxxx video serializer and deserializer. All the B?<bunch of numbers> part IDs got better of me :)

Yours,
-- Matti