Re: [PATCH V1 2/3] arm64: dts: qcom: sm8650: Add ICE algorithm entries
From: Krzysztof Kozlowski
Date: Sun Oct 06 2024 - 04:32:44 EST
On 05/10/2024 08:43, Ram Kumar Dwivedi wrote:
> There are three algorithms supported for inline crypto engine:
> Floor based, Static and Instantaneous algorithm.
>
> Add ice algorithm entries and enable instantaneous algorithm
> by default.
>
> Co-developed-by: Naveen Kumar Goud Arepalli <quic_narepall@xxxxxxxxxxx>
> Signed-off-by: Naveen Kumar Goud Arepalli <quic_narepall@xxxxxxxxxxx>
> Co-developed-by: Nitin Rawat <quic_nitirawa@xxxxxxxxxxx>
> Signed-off-by: Nitin Rawat <quic_nitirawa@xxxxxxxxxxx>
> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sm8650.dtsi | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index 9d9bbb9aca64..56a7ca6a3af4 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -2590,6 +2590,25 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
> #reset-cells = <1>;
>
> status = "disabled";
> +
> + ice_cfg: ice-config {
> + alg1 {
> + alg-name = "alg1";
> + rx-alloc-percent = <60>;
> + status = "disabled";
> + };
> +
> + alg2 {
> + alg-name = "alg2";
> + status = "disabled";
> + };
> +
> + alg3 {
> + alg-name = "alg3";
> + num-core = <28 28 15 13>;
> + status = "ok";
NAK. This has so many issues... First, describes OS policy. Second,
there is no "ok".
Best regards,
Krzysztof