Re: [PATCH V3 1/1] livepatch: Add "stack_order" sysfs attribute

From: zhang warden
Date: Sun Oct 06 2024 - 04:32:56 EST




> On Oct 3, 2024, at 23:25, Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
>
> On Thu, Oct 03, 2024 at 10:59:11PM +0800, zhang warden wrote:
>>> This attribute specifies the sequence in which live patch modules
>>> are applied to the system. If multiple live patches modify the same
>>> function, the implementation with the highest stack order is used,
>>> unless a transition is currently in progress.
>>
>> This description looks good to me. What's the suggestion of
>> other maintainers ?
>
> I like it, though "highest stack order" is still a bit arbitrary, since
> the highest stack order is actually the lowest number.
>
> --
> Josh

How about:

This attribute specifies the sequence in which live patch module
are applied to the system. If multiple live patches modify the same
function, the implementation with the biggest 'stack_order' number
is used, unless a transition is currently in progress.

Regards.
Wardenjohn.