Re: [PATCH 1/4] dt-bindings: rng: add st,stm32mp25-rng support

From: Gatien CHEVALLIER
Date: Mon Oct 07 2024 - 11:00:48 EST




On 10/7/24 15:53, Marek Vasut wrote:
On 10/7/24 3:27 PM, Gatien Chevallier wrote:
Add RNG STM32MP25x platforms compatible. Update the clock
properties management to support all versions.

Signed-off-by: Gatien Chevallier <gatien.chevallier@xxxxxxxxxxx>
---
  .../devicetree/bindings/rng/st,stm32-rng.yaml | 41 +++++++++++++++++--
  1 file changed, 38 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml
index 340d01d481d1..c92ce92b6ac9 100644
--- a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml
+++ b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml
@@ -18,12 +18,19 @@ properties:
      enum:
        - st,stm32-rng
        - st,stm32mp13-rng
+      - st,stm32mp25-rng
    reg:
      maxItems: 1
    clocks:
-    maxItems: 1
+    minItems: 1
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: rng_clk
+      - const: rng_hclk
    resets:
      maxItems: 1
@@ -57,15 +64,43 @@ allOf:
        properties:
          st,rng-lock-conf: false
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - st,stm32mp25-rng
Maybe this match should be inverted, it is likely the next generation of stm32 will also use 2 input clock into the RNG block and it will be only the legacy MP1 that uses one clock.

Hi, sure, makes more sense, I'll change it for V2.

Gatien