Re: [PATCH 1/2] dt-bindings: mmc: mmc-pwrseq-simple: add support for reset control

From: POPESCU Catalin
Date: Mon Oct 07 2024 - 11:33:49 EST


On 05/10/2024 20:26, Rob Herring wrote:
> [Some people who received this message don't often get email from robh@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> On Fri, Oct 04, 2024 at 02:07:39PM +0200, Catalin Popescu wrote:
>> Add compatible value "mmc-pwrseq-simple-reset" to support reset control
>> instead of gpios. Reset controls being refcounted, they allow to use
>> shared resets or gpios across drivers. Support of reset control is
>> limited to one single reset control.
> Can't you do this without a binding change? Just use reset controls when
> there is only 1 GPIO.

That's a good question. The idea was to keep in place the gpio support
w/o impacting any platform using pwrseq-simple.

Also, later on when support for a list of reset gpios will be added to
the reset framework, this would not work anymore...

>
>> Signed-off-by: Catalin Popescu <catalin.popescu@xxxxxxxxxxxxxxxxxxxx>
>> ---
>> .../bindings/mmc/mmc-pwrseq-simple.yaml | 21 +++++++++++++++++--
>> 1 file changed, 19 insertions(+), 2 deletions(-)