Re: [PATCH v4 2/2] Bluetooth: btnxpuart: Add GPIO support to power save feature
From: kernel test robot
Date: Tue Oct 08 2024 - 04:05:18 EST
Hi Neeraj,
kernel test robot noticed the following build errors:
[auto build test ERROR on bluetooth/master]
[also build test ERROR on bluetooth-next/master robh/for-next linus/master v6.12-rc2 next-20241004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Neeraj-Sanjay-Kale/dt-bindings-net-bluetooth-nxp-Add-support-for-power-save-feature-using-GPIO/20241007-211315
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/20241007131316.626690-3-neeraj.sanjaykale%40nxp.com
patch subject: [PATCH v4 2/2] Bluetooth: btnxpuart: Add GPIO support to power save feature
config: x86_64-buildonly-randconfig-003-20241008 (https://download.01.org/0day-ci/archive/20241008/202410081424.BaGORAHw-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241008/202410081424.BaGORAHw-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410081424.BaGORAHw-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/bluetooth/btnxpuart.c:445:7: error: expected ')'
445 | PTR_ERR(psdata->h2c_ps_gpio));
| ^
drivers/bluetooth/btnxpuart.c:444:3: note: to match this '('
444 | bt_dev_err(hdev, "Error fetching device-wakeup-gpios: %ld"
| ^
include/net/bluetooth/bluetooth.h:278:2: note: expanded from macro 'bt_dev_err'
278 | BT_ERR("%s: " fmt, bt_dev_name(hdev), ##__VA_ARGS__)
| ^
include/net/bluetooth/bluetooth.h:263:32: note: expanded from macro 'BT_ERR'
263 | #define BT_ERR(fmt, ...) bt_err(fmt "\n", ##__VA_ARGS__)
| ^
1 error generated.
vim +445 drivers/bluetooth/btnxpuart.c
434
435 static int ps_setup(struct hci_dev *hdev)
436 {
437 struct btnxpuart_dev *nxpdev = hci_get_drvdata(hdev);
438 struct serdev_device *serdev = nxpdev->serdev;
439 struct ps_data *psdata = &nxpdev->psdata;
440
441 psdata->h2c_ps_gpio = devm_gpiod_get_optional(&serdev->dev, "device-wakeup",
442 GPIOD_OUT_LOW);
443 if (IS_ERR(psdata->h2c_ps_gpio)) {
444 bt_dev_err(hdev, "Error fetching device-wakeup-gpios: %ld"
> 445 PTR_ERR(psdata->h2c_ps_gpio));
446 return PTR_ERR(psdata->h2c_ps_gpio);
447 }
448
449 if (!psdata->h2c_ps_gpio)
450 psdata->h2c_wakeup_gpio = 0xff;
451
452 psdata->hdev = hdev;
453 INIT_WORK(&psdata->work, ps_work_func);
454 mutex_init(&psdata->ps_lock);
455 timer_setup(&psdata->ps_timer, ps_timeout_func, 0);
456
457 return 0;
458 }
459
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki