Re: [PATCH] objtool: Deal with relative jump tables correctly

From: Josh Poimboeuf
Date: Tue Oct 08 2024 - 13:42:10 EST


On Tue, Oct 08, 2024 at 12:47:48AM +0200, Ard Biesheuvel wrote:
> - /*
> - * Use of RIP-relative switch jumps is quite rare, and
> - * indicates a rare GCC quirk/bug which can leave dead
> - * code behind.
> - */
> - if (reloc_type(text_reloc) == R_X86_64_PC32)
> - file->ignore_unreachables = true;
> -

I'm not sure if this bug still exists on current GCC versions. If so,
it will start reporting "unreachable instruction" warnings again and
we'll have to figure out a way to resolve that.

Otherwise the patch looks ok.

--
Josh