Re: [PATCH 0/2] nvme: add rotational support

[Matias Bjørling]

On 09-10-2024 09:43, Christoph Hellwig wrote:
> On Tue, Oct 08, 2024 at 04:55:01PM +0200, Matias Bjørling wrote:
> > From: Matias Bjørling <matias.bjorling@xxxxxxx>
> >
> > Enable support for NVMe devices that identifies as rotational.
> >
> > Thanks to Keith, Damien, and Niklas for their feedback on the patchset.
>
> Hmm, the only previous version I've seen was the the RFCs from
> Wang Yugui, last seen in August.
>
> What the improvement over that version?  Note that it also came
> with basic nvmet support which is kinda nice.

Ah, I made the patches without awareness of the earlier efforts.

This version, together with Keith's nvmet patch, does not rely on 
setting/checking the CRIMS flag.