Re: [PATCH 0/2] nvme: add rotational support

From: Keith Busch
Date: Wed Oct 09 2024 - 12:04:50 EST


On Wed, Oct 09, 2024 at 09:43:55AM +0200, Christoph Hellwig wrote:
> On Tue, Oct 08, 2024 at 04:55:01PM +0200, Matias Bjørling wrote:
> > From: Matias Bjørling <matias.bjorling@xxxxxxx>
> >
> > Enable support for NVMe devices that identifies as rotational.
> >
> > Thanks to Keith, Damien, and Niklas for their feedback on the patchset.
>
> Hmm, the only previous version I've seen was the the RFCs from
> Wang Yugui, last seen in August.

Oops, that slipped by me as well. I think the right thing to do is bring
that one forward and retain the original credit. I agree with Matias
that we ought to be able to query the independent identification without
relying on CRWMS, though.