Re: [PATCH] perf callchain: Remove unused callchain_branch_counts
From: Namhyung Kim
Date: Wed Oct 09 2024 - 20:33:50 EST
On Wed, Oct 09, 2024 at 11:27:16AM -0400, Liang, Kan wrote:
>
>
> On 2024-10-09 1:30 a.m., Namhyung Kim wrote:
> > On Sun, Oct 06, 2024 at 02:22:04AM +0100, linux@xxxxxxxxxxx wrote:
> >> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> >>
> >> callchain_branch_counts() was added in 2016 by commit
> >> 3dd029ef9401 ("perf report: Calculate and return the branch flag counting")
> >> but unused.
>
> It seems the original patchset was not well organized. This function is
> actually used by the last patch of the series.
> https://lore.kernel.org/lkml/1477876794-30749-7-git-send-email-yao.jin@xxxxxxxxxxxxxxx/
>
> But for some reason, the last patch was not merged. I think Andi gave
> the Acked-by for the whole series. It might be just accidentally missed.
>
> I think the missed feature is still useful.
> We will redo the test and re-post it.
Great, thanks for taking care of this.
Namhyung