Re: [PATCH] perf callchain: Remove unused callchain_branch_counts

[Namhyung Kim]

On Wed, Oct 09, 2024 at 04:50:53PM +0000, Dr. David Alan Gilbert wrote:
> * Liang, Kan (kan.liang@xxxxxxxxxxxxxxx) wrote:
> > 
> > 
> > On 2024-10-09 1:30 a.m., Namhyung Kim wrote:
> > > On Sun, Oct 06, 2024 at 02:22:04AM +0100, linux@xxxxxxxxxxx wrote:
> > >> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > >>
> > >> callchain_branch_counts() was added in 2016 by commit
> > >> 3dd029ef9401 ("perf report: Calculate and return the branch flag counting")
> > >> but unused.
> > 
> > It seems the original patchset was not well organized. This function is
> > actually used by the last patch of the series.
> > https://lore.kernel.org/lkml/1477876794-30749-7-git-send-email-yao.jin@xxxxxxxxxxxxxxx/
> > 
> > But for some reason, the last patch was not merged. I think Andi gave
> > the Acked-by for the whole series. It might be just accidentally missed.
> 
> OK, that'll be the 4th time this deadcode series has found missing calls
> to functions!

Nice work! :)

Thanks,
Namhyung