Re: [PATCH v2] ftrace/selftest: Test combination of function_graph tracer and function profiler

From: Steven Rostedt
Date: Thu Oct 10 2024 - 13:31:49 EST


On Thu, 10 Oct 2024 11:04:43 -0600
Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote:

> On 10/7/24 18:33, Masami Hiramatsu (Google) wrote:
> > On Fri, 4 Oct 2024 14:56:18 -0400
> > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> >> From: Steven Rostedt <rostedt@xxxxxxxxxxx>
> >>
> >> Masami reported a bug when running function graph tracing then the
> >> function profiler. The following commands would cause a kernel crash:
> >>
> >> # cd /sys/kernel/tracing/
> >> # echo function_graph > current_tracer
> >> # echo 1 > function_profile_enabled
> >>
> >> In that order. Create a test to test this two to make sure this does not
> >> come back as a regression.
> >>
> >> Link: https://lore.kernel.org/172398528350.293426.8347220120333730248.stgit@devnote2
> >>
> >
> > Looks good to me.
> >
> > Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> >
> > Thanks!
> >
> >> Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
>
> Steve, Would you like me take this one through my tree?
>

Yes please.

Thanks Shuah!

-- Steve