Re: [PATCH] mm: Enforce a minimal stack gap even against inaccessible VMAs

[Lorenzo Stoakes]

On Wed, Oct 09, 2024 at 02:08:22PM -0700, Andrew Morton wrote:
> On Wed, 9 Oct 2024 15:53:50 +0100 Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> wrote:
>
> > > All errors (new ones prefixed by >>):
> > >
> > >    mm/mmap.c: In function 'expand_upwards':
> > > >> mm/mmap.c:1069:39: error: 'prev' undeclared (first use in this function)
> > >     1069 |                 if (vma_is_accessible(prev))
> >
> > Suspect this is just a simple typo and should be next rather than prev :>)
>
> Agree, I'll make that change.
>
> CONFIG_STACK_GROWSUP is only a parisc thing.  That makes runtime
> testing difficult.

Hi Andrew,

Would it be possible to drop this for now as it is not clear we want to
take this approach and there is some concern this could break some things?

I believe Jann was going to provide an alternative that attacked this from
the mmap()/mprotect() side also?

Thanks!