Re: [PATCHv6 bpf-next 15/16] selftests/bpf: Add uprobe sessions to consumer test

[Andrii Nakryiko]

On Thu, Oct 10, 2024 at 1:13 PM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
>
> Adding uprobe session consumers to the consumer test,
> so we get the session into the test mix.
>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> ---
>  .../bpf/prog_tests/uprobe_multi_test.c        | 63 +++++++++++++++----
>  .../bpf/progs/uprobe_multi_consumers.c        | 16 ++++-
>  2 files changed, 66 insertions(+), 13 deletions(-)
>

you are undoing most of the changes done in the previous patch... it
seems like it would be better to just combine  both patches

> diff --git a/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> index 2effe4d693b4..df9314309bc3 100644
> --- a/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> +++ b/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> @@ -761,6 +761,10 @@ get_program(struct uprobe_multi_consumers *skel, int prog)
>                 return skel->progs.uprobe_0;
>         case 1:
>                 return skel->progs.uprobe_1;
> +       case 2:
> +               return skel->progs.uprobe_2;
> +       case 3:
> +               return skel->progs.uprobe_3;
>         default:
>                 ASSERT_FAIL("get_program");
>                 return NULL;

[...]