RE: [PATCH net] net: enetc: add missing static descriptor and inline keyword

From: Claudiu Manoil
Date: Fri Oct 11 2024 - 03:13:03 EST


> -----Original Message-----
> From: Wei Fang <wei.fang@xxxxxxx>
> Sent: Friday, October 11, 2024 6:01 AM
[...]
> Subject: [PATCH net] net: enetc: add missing static descriptor and inline
> keyword
>
> Fix the build warnings when CONFIG_FSL_ENETC_MDIO is not enabled.
> The detailed warnings are shown as follows.
>
> include/linux/fsl/enetc_mdio.h:62:18: warning: no previous prototype for
> function 'enetc_hw_alloc' [-Wmissing-prototypes]
> 62 | struct enetc_hw *enetc_hw_alloc(struct device *dev, void __iomem
> *port_regs)
> | ^
> include/linux/fsl/enetc_mdio.h:62:1: note: declare 'static' if the function is not
> intended to be used outside of this translation unit
> 62 | struct enetc_hw *enetc_hw_alloc(struct device *dev, void __iomem
> *port_regs)
> | ^
> | static
> 8 warnings generated.
>
> Fixes: 6517798dd343 ("enetc: Make MDIO accessors more generic and export
> to include/linux/fsl")

Reviewed-by: Claudiu Manoil <claudiu.manoil@xxxxxxx>