Re: [PATCH net] net: enetc: add missing static descriptor and inline keyword

From: Vladimir Oltean
Date: Fri Oct 11 2024 - 10:45:02 EST


On Fri, Oct 11, 2024 at 11:01:03AM +0800, Wei Fang wrote:
> Fix the build warnings when CONFIG_FSL_ENETC_MDIO is not enabled.
> The detailed warnings are shown as follows.
>
> include/linux/fsl/enetc_mdio.h:62:18: warning: no previous prototype for function 'enetc_hw_alloc' [-Wmissing-prototypes]
> 62 | struct enetc_hw *enetc_hw_alloc(struct device *dev, void __iomem *port_regs)
> | ^
> include/linux/fsl/enetc_mdio.h:62:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> 62 | struct enetc_hw *enetc_hw_alloc(struct device *dev, void __iomem *port_regs)
> | ^
> | static
> 8 warnings generated.
>
> Fixes: 6517798dd343 ("enetc: Make MDIO accessors more generic and export to include/linux/fsl")
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410102136.jQHZOcS4-lkp@xxxxxxxxx/
> Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>