Re: [PATCH v3 7/8] arm64: dts: qcom: sc7280: Add support for camss

[Krzysztof Kozlowski]

On Fri, Oct 11, 2024 at 07:39:31PM +0530, Vikram Sharma wrote:
> Add changes to support the camera subsystem on the SC7280.
> 
> Signed-off-by: Suresh Vankadara <quic_svankada@xxxxxxxxxxx>
> Signed-off-by: Trishansh Bhardwaj <quic_tbhardwa@xxxxxxxxxxx>
> Signed-off-by: Vikram Sharma <quic_vikramsa@xxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 175 +++++++++++++++++++++++++++
>  1 file changed, 175 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index b41230651def..9bab2d8dc1b4 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -4426,6 +4426,181 @@ cci1_i2c1: i2c-bus@1 {
>  			};
>  		};
>  
> +		camss: camss@acaf000 {
> +			compatible = "qcom,sc7280-camss";
> +
> +			clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>,
> +				<&camcc CAM_CC_IFE_0_CSID_CLK>,
> +				<&camcc CAM_CC_IFE_1_CSID_CLK>,
> +				<&camcc CAM_CC_IFE_2_CSID_CLK>,
> +				<&camcc CAM_CC_IFE_LITE_0_CSID_CLK>,
> +				<&camcc CAM_CC_IFE_LITE_1_CSID_CLK>,
> +				<&camcc CAM_CC_CSIPHY0_CLK>,
> +				<&camcc CAM_CC_CSI0PHYTIMER_CLK>,
> +				<&camcc CAM_CC_CSIPHY1_CLK>,
> +				<&camcc CAM_CC_CSI1PHYTIMER_CLK>,
> +				<&camcc CAM_CC_CSIPHY2_CLK>,
> +				<&camcc CAM_CC_CSI2PHYTIMER_CLK>,
> +				<&camcc CAM_CC_CSIPHY3_CLK>,
> +				<&camcc CAM_CC_CSI3PHYTIMER_CLK>,
> +				<&camcc CAM_CC_CSIPHY4_CLK>,
> +				<&camcc CAM_CC_CSI4PHYTIMER_CLK>,
> +				<&gcc GCC_CAMERA_AHB_CLK>,
> +				<&gcc GCC_CAMERA_HF_AXI_CLK>,
> +				<&camcc CAM_CC_CPAS_AHB_CLK>,
> +				<&camcc CAM_CC_IFE_0_AXI_CLK>,
> +				<&camcc CAM_CC_IFE_0_CLK>,
> +				<&camcc CAM_CC_IFE_0_CPHY_RX_CLK>,
> +				<&camcc CAM_CC_IFE_1_AXI_CLK>,
> +				<&camcc CAM_CC_IFE_1_CLK>,
> +				<&camcc CAM_CC_IFE_1_CPHY_RX_CLK>,
> +				<&camcc CAM_CC_IFE_2_AXI_CLK>,
> +				<&camcc CAM_CC_IFE_2_CLK>,
> +				<&camcc CAM_CC_IFE_2_CPHY_RX_CLK>,
> +				<&camcc CAM_CC_IFE_LITE_0_CLK>,
> +				<&camcc CAM_CC_IFE_LITE_0_CPHY_RX_CLK>,
> +				<&camcc CAM_CC_IFE_LITE_1_CLK>,
> +				<&camcc CAM_CC_IFE_LITE_1_CPHY_RX_CLK>;
> +
> +			clock-names = "camnoc_axi",
> +				"csi0",
> +				"csi1",

Everything misaligned here as well.

Best regards,
Krzysztof