Re: [PATCH 2/2] maple_tree: Add some alloc node test case

[Liam R. Howlett]

* Wei Yang <richard.weiyang@xxxxxxxxx> [241010 21:18]:
> On Wed, Jun 26, 2024 at 12:06:31PM -0400, Liam R. Howlett wrote:
> >From: Jiazi Li <jqqlijiazi@xxxxxxxxx>
> >
> >Add some maple_tree alloc node tese case.
> >
> >Suggested-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
> >Signed-off-by: Jiazi Li <jqqlijiazi@xxxxxxxxx>
> >Signed-off-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
> >---
> > tools/testing/radix-tree/maple.c | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> >diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
> >index 11f1efdf83f9..b4b5fd9f294d 100644
> >--- a/tools/testing/radix-tree/maple.c
> >+++ b/tools/testing/radix-tree/maple.c
> >@@ -462,6 +462,28 @@ static noinline void __init check_new_node(struct maple_tree *mt)
> > 	MT_BUG_ON(mt, mas_allocated(&mas) != 10 + MAPLE_ALLOC_SLOTS - 1);
> > 	mas_destroy(&mas);
> > 
> >+	mas.node = MA_ERROR(-ENOMEM);
> >+	mas_node_count(&mas, MAPLE_ALLOC_SLOTS + 1); /* Request */
> >+	mas_nomem(&mas, GFP_KERNEL); /* Fill request */
> 
> I am not sure why mas_nomem() is here.
> 
> Without this one, we still can trigger the original bug.

It will fill the maple state allocation.  Might not be needed but
doesn't hurt.

> 
> >+	MT_BUG_ON(mt, mas_allocated(&mas) != MAPLE_ALLOC_SLOTS + 1);
> >+	mas.node = MA_ERROR(-ENOMEM);
> >+	mas_node_count(&mas, MAPLE_ALLOC_SLOTS * 2 + 2); /* Request */
> >+	mas_nomem(&mas, GFP_KERNEL); /* Fill request */
> >+	mas.status = ma_start;
> >+	MT_BUG_ON(mt, mas_allocated(&mas) != MAPLE_ALLOC_SLOTS * 2 + 2);
> >+	mas_destroy(&mas);
> >+
> >+	mas.node = MA_ERROR(-ENOMEM);
> >+	mas_node_count(&mas, MAPLE_ALLOC_SLOTS * 2 + 1); /* Request */
> >+	mas_nomem(&mas, GFP_KERNEL); /* Fill request */
> >+	MT_BUG_ON(mt, mas_allocated(&mas) != MAPLE_ALLOC_SLOTS * 2 + 1);
> >+	mas.node = MA_ERROR(-ENOMEM);
> >+	mas_node_count(&mas, MAPLE_ALLOC_SLOTS * 3 + 2); /* Request */
> >+	mas_nomem(&mas, GFP_KERNEL); /* Fill request */
> >+	mas.status = ma_start;
> >+	MT_BUG_ON(mt, mas_allocated(&mas) != MAPLE_ALLOC_SLOTS * 3 + 2);
> >+	mas_destroy(&mas);
> >+
> > 	mtree_unlock(mt);
> > }
> > 
> >-- 
> >2.43.0
> >
> 
> -- 
> Wei Yang
> Help you, Help me