Re: [PATCH v3 1/3] dt-bindings: mmc: controller: move properties common with slot out to mmc-controller-common

[Neil Armstrong]

Hi Rob,

On 07/10/2024 22:02, Rob Herring wrote:
> On Mon, Oct 07, 2024 at 04:03:37PM +0200, Neil Armstrong wrote:
> > Move the common MMC "slot" properties because they are shared by the
> > single-slot or multi-slot controllers, and will help defining a simple
> > mmc-slot bindings document with proper slot properties and nodename.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   .../bindings/mmc/mmc-controller-common.yaml        | 357 +++++++++++++++++++++
> >   .../devicetree/bindings/mmc/mmc-controller.yaml    | 344 +-------------------
> >   2 files changed, 360 insertions(+), 341 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> > new file mode 100644
> > index 000000000000..e02d3cbcc271
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> > @@ -0,0 +1,357 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mmc/mmc-controller-common.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MMC Controller & Slots Common Properties
> > +
> > +maintainers:
> > +  - Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> > +
> > +description: |
> > +  These properties are common to multiple MMC host controllers and the
> > +  possible slots or ports for multi-slot controllers.
> > +
> > +properties:
> > +  "#address-cells":
> > +    const: 1
> > +    description: |
> > +      The cell is the slot ID if a function subnode is used.
>
> Actually, this comment is wrong. When slot is used, this is still the
> cell size for the mmc bus.

I don't understand, the comment is still valid, MMC slots can have function subnodes
aswell, perhaps the "slot ID" is confusing here ? here it stands for the MMC protocol
slot ID, not the physical slot of the multi-slot MMC controller.

Neil