Re: [RFC PATCH v2 2/2] rtc: add driver for Marvell 88PM886 PMIC RTC

From: Lee Jones
Date: Tue Oct 15 2024 - 04:35:41 EST


On Sat, 12 Oct 2024, Karel Balej wrote:

> RTC lives on the chip's base register page. Add the relevant register
> definitions and implement a basic set/read time functionality. Tested
> with the samsung,coreprimevelte smartphone which contains this PMIC and
> whose vendor kernel tree has also served as the sole reference for this.
>
> Signed-off-by: Karel Balej <balejk@xxxxxxxxx>
> ---
>
> Notes:
> RFC v2:
> - Move in the register definitions from the preceding patch and reword
> the commit message accordingly.
> - Rebase to v6.12-rc2.
>
> MAINTAINERS | 1 +
> drivers/rtc/Kconfig | 10 ++++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-88pm886.c | 97 +++++++++++++++++++++++++++++++++++++
> include/linux/mfd/88pm886.h | 9 ++++

Acked-by: Lee Jones <lee@xxxxxxxxxx>

> 5 files changed, 118 insertions(+)
> create mode 100644 drivers/rtc/rtc-88pm886.c

--
Lee Jones [李琼斯]