Re: [PATCH] staging: gpib: Remove unused value

[Everest K.C.]

On Wed, Oct 16, 2024 at 1:37 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Oct 15, 2024 at 03:02:57PM -0600, Everest K.C. wrote:
> > The variable `complement_count` is assigned a value which is again
> > overwritten in the next statement.
> > Fix this by removing the first value assigning statement
> >
> > This issue was reported by Coverity Scan.
> > Report:
> > CID 1600790: (#1 of 1): Unused value (UNUSED_VALUE)
> > assigned_value: Assigning value from length to complement_count here,
> > but that stored value is overwritten before it can be used.
> >
> > Fixes: 4e127de14fa7 ("staging: gpib: Add National Instruments USB GPIB driver")
>
> Thre is no "fix" needed here.  It's not a bug, just a useless operation
> (one tha tthe compiler probably just compiles away into nothing.)  So
> there is no need for a Fixes: tag, sorry.
Noted. Will remove the fixes tag and send V2.
> thanks,
>
> greg k-h
Thanks,
Everest K.C.