Re: [PATCH][next] media: i2c: ds90ub960: Fix missing return check on ub960_rxport_read call

[Mauro Carvalho Chehab]

Em Wed,  2 Oct 2024 17:53:29 +0100
Colin Ian King <colin.i.king@xxxxxxxxx> escreveu:

> The function ub960_rxport_read is being called and afterwards ret is
> being checked for any failures, however ret is not being assigned to
> the return of the function call. Fix this by assigning ret to the
> return of the call which appears to be missing.
> 
> Fixes: afe267f2d368 ("media: i2c: add DS90UB960 driver")
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

No Cc: stable. Please follow the submission rules for fixes as stated
at:
	Documentation/process/stable-kernel-rules.rst

In summary, all patches containing fixes shall have a Cc stable. There 
are rules there for the very few exceptions where a patch is not meant
to be backported:

     Cc: <stable+noautosel@xxxxxxxxxx> # reason goes here, and must be present



> ---
>  drivers/media/i2c/ds90ub960.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
> index ffe5f25f8647..58424d8f72af 100644
> --- a/drivers/media/i2c/ds90ub960.c
> +++ b/drivers/media/i2c/ds90ub960.c
> @@ -1286,7 +1286,7 @@ static int ub960_rxport_get_strobe_pos(struct ub960_data *priv,
>  
>  	clk_delay += v & UB960_IR_RX_ANA_STROBE_SET_CLK_DELAY_MASK;
>  
> -	ub960_rxport_read(priv, nport, UB960_RR_SFILTER_STS_1, &v);
> +	ret = ub960_rxport_read(priv, nport, UB960_RR_SFILTER_STS_1, &v);
>  	if (ret)
>  		return ret;
>  



Thanks,
Mauro