Re: [PATCH v3 1/5] rtc: pm8xxx: implement qcom,no-alarm flag for non-HLOS owned alarm

[Jonathan Marek]

On 10/16/24 9:02 AM, Johan Hovold wrote:
> > > >    	int alarm_irq;
> > > >    	const struct pm8xxx_rtc_regs *regs;
> > > >    	struct device *dev;
> > > > @@ -473,9 +474,14 @@ static int pm8xxx_rtc_probe(struct platform_device *pdev)
> > > >    	if (!rtc_dd->regmap)
> > > >    		return -ENXIO;
> > > >    
> > > > -	rtc_dd->alarm_irq = platform_get_irq(pdev, 0);
> > > > -	if (rtc_dd->alarm_irq < 0)
> > > > -		return -ENXIO;
> > > > +	rtc_dd->no_alarm = of_property_read_bool(pdev->dev.of_node,
> > > > +						 "qcom,no-alarm");
> > > > +
> > >
> > > Stray newline.
> >
> > That's not a stray newline?
>
> There was no empty line between the assignment and check before this
> change, but now there is even though there should not be.
>   

There was no empty line between the "alarm_irq" assignment and check, 
and there still isn't. That empty line separating the new 
of_property_read_bool() line.

I could move both of_property_read_bool() lines together to make it look 
better.

> > > > +	if (!rtc_dd->no_alarm) {
> > > > +		rtc_dd->alarm_irq = platform_get_irq(pdev, 0);
> > > > +		if (rtc_dd->alarm_irq < 0)
> > > > +			return -ENXIO;
> > > > +	}
>
> Johan