RE: [PATCH v2 08/10] x86/mce: Remove the redundant zeroing assignments
From: Zhuo, Qiuxu
Date: Mon Oct 21 2024 - 02:29:28 EST
> From: H. Peter Anvin <hpa@xxxxxxxxx>
> [...]
> >This is a good tip to quickly check whether a cleanup of removing
> >unnecessary assignments changes the function. If there is no difference
> >in the text before and after the cleanup, then it's OK. Otherwise, the
> >cleanup probably changes the function in an unintended way.
> >
> >-Qiuxu
> >
>
> Yes and no. Deleting things like redundant reinitialization should only be done
> if it makes the code clearer. You can think of the redundant statements as
> comments/asserts.
Thanks for the further clarification.
-Qiuxu