Re: [PATCH v6 3/5] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

[Naik, Avadhut]

On 10/18/2024 10:28, Luck, Tony wrote:
>> So, this is based on the assumption that all vendor data fields are of the u64 type, which may
>> NOT be true for other x86 vendors in the future. In case there is some non-u64 vendor data in
>> the future, the parser would need to break the u64 tracing data into u8 data and then composite
>> the split u8 data into other types like u16 or u32, which seems even inconvenient.
>>
>> IMHO: Printing the u8 tracing data and leaving the vendor-specific tool to parse the u8 data is a
>> more flexible and balanced approach.
>>
>> Maybe Boris and Tony could provide more comments here.
> 
> I agree. It's hard to predict the future, but there seems to be no guarantee that
> vendor specific fields will always be "u64" sized. Perhaps the MSR that data
> is picked from has only a few bits defined so we elect to save those bits in
> some smaller data type.
> 
> -Tony
Okay, sounds good! As recommended, will change that parameter to sizeof(u8).

-- 
Thanks,
Avadhut Naik