Re: [PATCH] media: platform: mtk-mdp3: cmdq: Remove duplicated platforms checks

[AngeloGioacchino Del Regno]

Il 17/10/24 22:16, Mohammed Anees ha scritto:
> The platform compatibility checks for MT8183 and
> MT8195 in mdp_cmdq_prepare() are redundant as they are
> done in __get_config_offset() itself. Furthermore
> there are two if-else branch in __get_config_offset()
> which have similar conditions and are redundant.
> To address this, remove the check in mdp_cmdq_prepare()
> and combine the two if-else branch into one in
> __get_config_offset().
>
> Signed-off-by: Mohammed Anees <pvmohammedanees2003@xxxxxxxxx>

This should've been [PATCH v2], because this *is* a version 2: even if you
have changed the title a bit, it's still "the same" patch ;-)

Next time, please version your patches correctly.

Anyway, apart from this not being declared as v2, this time I'll let you
get my

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

...because the patch is good, and because it's only the first time that I warn
you about this :-)

Keep up the good work!

Cheers,
Angelo