Re: [PATCH v3 12/15] drm/bridge: Add ITE IT6263 LVDS to HDMI converter
From: Maxime Ripard
Date: Mon Oct 21 2024 - 08:38:52 EST
On Mon, Oct 21, 2024 at 02:44:43PM +0800, Liu Ying wrote:
> +static int it6263_bridge_atomic_check(struct drm_bridge *bridge,
> + struct drm_bridge_state *bridge_state,
> + struct drm_crtc_state *crtc_state,
> + struct drm_connector_state *conn_state)
> +{
> + struct drm_display_mode *mode = &crtc_state->adjusted_mode;
> + int ret;
> +
> + ret = drm_atomic_helper_connector_hdmi_check(conn_state->connector,
> + conn_state->state);
> + if (ret)
> + return ret;
> +
> + return mode->clock > MAX_PIXEL_CLOCK_KHZ ? -EINVAL : 0;
drm_atomic_helper_connector_hdmi_check will already make that check, so
it's redundant.
Once fixed
Acked-by: Maxime Ripard <mripard@xxxxxxxxxx>
Maxime
Attachment:
signature.asc
Description: PGP signature