Re: [PATCH v3 12/15] drm/bridge: Add ITE IT6263 LVDS to HDMI converter

[Liu Ying]

On 10/21/2024, Biju Das wrote:
> Hi Liu Ying,

Hi Biju,

> 
> Thanks for the patch.

Thanks for your review.

[...]

>> +struct it6263 {
>> +	struct device *dev;
>> +	struct i2c_client *hdmi_i2c;
>> +	struct i2c_client *lvds_i2c;
>> +	struct regmap *hdmi_regmap;
>> +	struct regmap *lvds_regmap;
>> +	struct drm_bridge bridge;
>> +	struct drm_bridge *next_bridge;
>> +	struct gpio_desc *reset_gpio;
> This can be dropped, since it is used only in probe().

Will do in next version.

> 
> With that fixed,
> 
> Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Cheers,
> Biju

-- 
Regards,
Liu Ying