RE: [PATCH v2 06/10] x86/mce: Convert multiple if () statements into a switch() statement
From: Zhuo, Qiuxu
Date: Wed Oct 23 2024 - 03:59:59 EST
> From: Mehta, Sohil <sohil.mehta@xxxxxxxxx>
> [...]
> On 10/22/2024 7:08 PM, Zhuo, Qiuxu wrote:
> > OK. So, back to your original question below, what is your answer to
> > it now? :-)
> >
> > "Can some of the hardcoded numbers be changed to vfm macros as
> well?"
> >
>
> Even though it takes a tiny bit of reading to understand the VFM macros, the
> pros significantly outweigh the cons. I still feel we should go ahead and make
> the changes.
Thanks for letting me know your thoughts.
To me, the VFM-based checks can make the code more compact.
So, if nobody else objects, I'll include this VFM-based check version in the next version.
- Qiuxu