Re: [PATCH v2 06/10] x86/mce: Convert multiple if () statements into a switch() statement

From: Sohil Mehta
Date: Wed Oct 23 2024 - 02:48:46 EST


On 10/22/2024 7:08 PM, Zhuo, Qiuxu wrote:
> OK. So, back to your original question below, what is your answer to it now? :-)
>
> "Can some of the hardcoded numbers be changed to vfm macros as well?"
>

Even though it takes a tiny bit of reading to understand the VFM macros,
the pros significantly outweigh the cons. I still feel we should go
ahead and make the changes.

I have responded with minor comments to your patch.

Sohil