Re: [PATCH net-next v4 2/2] netcons: Add udp send fail statistics to netconsole

From: Breno Leitao
Date: Mon Oct 28 2024 - 06:45:56 EST


On Sun, Oct 27, 2024 at 12:59:42PM -0700, Maksym Kutsevol wrote:
> Enhance observability of netconsole. Packet sends can fail.
> Start tracking at least two failure possibilities: ENOMEM and
> NET_XMIT_DROP for every target. Stats are exposed via an additional
> attribute in CONFIGFS.
>
> The exposed statistics allows easier debugging of cases when netconsole
> messages were not seen by receivers, eliminating the guesswork if the
> sender thinks that messages in question were sent out.
>
> Stats are not reset on enable/disable/change remote ip/etc, they
> belong to the netcons target itself.
>
> Reported-by: Breno Leitao <leitao@xxxxxxxxxx>
> Closes: https://lore.kernel.org/all/ZsWoUzyK5du9Ffl+@xxxxxxxxx/
> Signed-off-by: Maksym Kutsevol <max@xxxxxxxxxxxx>

Reviewed-by: Breno Leitao <leitao@xxxxxxxxxx>